// 数据模型classes import { Data } from 'hp-shared/src/base/index.js'; /** * classes */ // 将属性描述对象存储在特殊对象中用于判断 export class CustomDescriptor { constructor(descriptor = {}) { if ('value' in descriptor) { Object.assign(this, { wri...-Go服务器开发

Here are a few optimizations that could be made to the code:

Use object destructuring to simplify the constructor of CustomDescriptor:

constructor({ value, ...descriptor } = {}) {
  if (value) {
    Object.assign(this, {
      writable: true,
      enumerable: true,
      configurable: true,
      value,
    }, descriptor);
  } else {
    Object.assign(this, {
      enumerable: true,
      configurable: true,
    }, descriptor);
  }
}

Simplify the check for CustomObject in AppDataModel’s constructor:

if (!(value instanceof CustomObject)) {
  // Check for CustomDescriptor first
  if (value instanceof CustomDescriptor) {
    return new AppDataModel(custom({ descriptor: value }), { _rawValue: value });
  }
  // Check for type next
  const type = Data.getExactType(value);
  if (type === Function) {
    return new AppDataModel(custom({ type: value }), { _rawValue: value });
  }
  // Other values go into default
  return new AppDataModel(custom({ default: value }), { _rawValue: value });
}

Use computed property names to simplify the assignment of properties in AppDataModel’s constructor:

// Instead of this:
for (const key of ['type', 'maxLength', 'descriptor']) {
  if (key in value) {
    this[key] = value[key];
  }
}

// You can use computed property names like this:
for (const key of Object.keys(value)) {
  if (['type', 'maxLength', 'descriptor'].includes(key)) {
    this[key] = value[key];
  }
}

Use array methods like map and reduce instead of loops where possible:

// Instead of this:
let result = {};
for (const [key, val] of Object.entries(this.children) as any) {
  if (val.descriptor) {
    Object.defineProperty(result, key, val.descriptor);
  } else {
    result[key] = val.default;
  }
}

// You can use reduce like this:
const result = Object.entries(this.children).reduce((acc, [key, val]) => {
  if (val.descriptor) {
    Object.defineProperty(acc, key, val.descriptor);
  } else {
    acc[key] = val.default;
  }
  return acc;
}, {});

Use shorthand object methods to simplify the validator function in AppDataModel:

this.validator = (() => {
  const { validator } = value;
  if (!validator) {
    return this.defaultValidator;
  }
  const type = Data.getExactType(validator);
  
  // Use shorthand object methods here
  const validators = {
    Array: data => validator.includes(data),
    RegExp: data => validator.test(data),
    Function: validator,
  };

  return validators[type] || this.defaultValidator;
})();